Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unresolved function in "cloud_scripts" shell command. #169

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Fix unresolved function in "cloud_scripts" shell command. #169

merged 1 commit into from
Jan 7, 2025

Conversation

bb00
Copy link
Contributor

@bb00 bb00 commented Dec 18, 2024

Replace unresolvable function "query_scripts" with correct function "describe_scripts" from Caracara.

@bb00
Update prompt.py
87e4676 
Replace unresolvable function "query_scripts" with correct caracara function "describe_scripts".
@bb00
Copy link
Contributor Author

bb00 commented Jan 7, 2025

@ChristopherHammond13 Thoughts?
Also please see my pull request on caracara-filters for fixing filter enumeration.

ChristopherHammond13
ChristopherHammond13 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@ChristopherHammond13 ChristopherHammond13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this PR! Apologies for not seeing the PR when you first opened this a few weeks back.

@ChristopherHammond13 ChristopherHammond13 merged commit 135a462 into CrowdStrike:main Jan 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopherHammond13 ChristopherHammond13 ChristopherHammond13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bb00 @ChristopherHammond13